Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rekey partitioned epoch rewards #34502

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

HaoranYi
Copy link
Contributor

@HaoranYi HaoranYi commented Dec 18, 2023

Problem

I lost the key for partitioned epoch rewards feature when we migrated from gcp
boxes.

Summary of Changes

rekey partitioned epoch rewards feature

Fixes #
Feature Gate Issue: # #32166

@HaoranYi HaoranYi added the v1.17 PRs that should be backported to v1.17 label Dec 18, 2023
Copy link
Contributor

mergify bot commented Dec 18, 2023

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

@HaoranYi
Copy link
Contributor Author

This feature has been implemented since v1.17. And this pr should be backported to 1.17.

@brooksprumo brooksprumo added the feature-gate Pull Request adds or modifies a runtime feature gate label Dec 18, 2023
@brooksprumo
Copy link
Contributor

brooksprumo commented Dec 18, 2023

Lgtm

@HaoranYi Can you please include the GH issue # in the PR description where the

<!-- OPTIONAL: Feature Gate Issue: # -->

part is? (And remove the comments heh) I've already added the feature-gate label.

After this PR is merged, please also update the feature gate issue with the new id and version too.

@t-nelson I've requested a review from you too, to ensure we're not forgetting anything when rekeying. Thanks in advance!

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Merging #34502 (b4cdbdf) into master (4181ea4) will increase coverage by 0.0%.
Report is 1 commits behind head on master.
The diff coverage is 100.0%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #34502   +/-   ##
=======================================
  Coverage    81.8%    81.8%           
=======================================
  Files         820      820           
  Lines      220790   220790           
=======================================
+ Hits       180679   180704   +25     
+ Misses      40111    40086   -25     

@CriesofCarrots
Copy link
Contributor

Are the keys backed up this time?

Copy link
Contributor

@brooksprumo brooksprumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(forgot to give the actual approval last time)

@brooksprumo
Copy link
Contributor

brooksprumo commented Dec 18, 2023

Please also update the Feature Gate Activation Schedule with the new id (and version) after merging as well:
https://github.com/solana-labs/solana/wiki/Feature-Gate-Activation-Schedule

@HaoranYi
Copy link
Contributor Author

Are the keys backed up this time?

Yeah. Locally on my computer. But I am not sure how safe it is to store these keys on my computer locally. I wonder if we have a standardized location to store these feature keys.

@willhickey
Copy link
Contributor

Are the keys backed up this time?

Yeah. Locally on my computer. But I am not sure how safe it is to store these keys on my computer locally. I wonder if we have a standardized location to store these feature keys.

We don't have a standard. I guess a paper wallet would be smart but I think most people just keep them on their laptop or in private cloud storage.

Copy link
Contributor

@willhickey willhickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending follow up:

Update Issue #32166

  • Key
  • Min versions (v1.16.26 and v1.17.13)

Update feature gate schedule

  • Key
  • Min versions (include both v1.16.26 and v1.17.13)

@HaoranYi
Copy link
Contributor Author

HaoranYi commented Dec 18, 2023

Approved pending follow up:

Update Issue #32166

  • Key
  • Min versions (v1.16.26 and v1.17.13)

Update feature gate schedule

  • Key
  • Min versions (include both v1.16.26 and v1.17.13)

Updated feature gate and schedule.
To be clear, partitioned epoch reward is only available in v1.17., NOT available in v.1.16..

@HaoranYi
Copy link
Contributor Author

@t-nelson Can you review this PR? It should be quite straightforward. Thanks!

Copy link
Contributor

@t-nelson t-nelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@t-nelson Can you review this PR? It should be quite straightforward. Thanks!

sry i've been ooo

I wonder if we have a standardized location to store these feature keys.

that is called a "target" 😅

I guess a paper wallet would be smart

yes.

but I think most people just keep them on their laptop

i guess, so long as they're careful

or in private cloud storage.

fuck, i hope not

@HaoranYi HaoranYi merged commit 2fd0bae into solana-labs:master Dec 21, 2023
46 checks passed
mergify bot pushed a commit that referenced this pull request Dec 21, 2023
Co-authored-by: HaoranYi <haoran.yi@solana.com>
(cherry picked from commit 2fd0bae)
HaoranYi added a commit that referenced this pull request Dec 22, 2023
rekey partitioned epoch rewards (#34502)

Co-authored-by: HaoranYi <haoran.yi@solana.com>
(cherry picked from commit 2fd0bae)

Co-authored-by: HaoranYi <haoran.yi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-gate Pull Request adds or modifies a runtime feature gate v1.17 PRs that should be backported to v1.17
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants